Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use chronincles for logging #17272

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

use chronincles for logging #17272

wants to merge 2 commits into from

Conversation

arnetheduck
Copy link
Member

In a few places, std/logging was used which looks unintended

What does the PR do

Affected areas

Architecture compliance

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it

In a few places, std/logging was used which looks unintended
@arnetheduck arnetheduck requested review from a team as code owners February 11, 2025 14:51
@arnetheduck arnetheduck requested review from Cuteivist and Khushboo-dev-cpp and removed request for a team February 11, 2025 14:51
@status-im-auto
Copy link
Member

status-im-auto commented Feb 11, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 2da3be9 #1 2025-02-11 15:00:59 ~9 min macos/aarch64 🍎dmg
✖️ 2da3be9 #1 2025-02-11 15:01:13 ~9 min tests/nim 📄log
✔️ 2da3be9 #1 2025-02-11 15:05:22 ~13 min tests/ui 📄log
✔️ 2da3be9 #1 2025-02-11 15:10:40 ~18 min macos/x86_64 🍎dmg
✔️ 2da3be9 #1 2025-02-11 15:11:25 ~19 min linux/x86_64 📦tgz
✔️ 2da3be9 #1 2025-02-11 15:11:27 ~19 min linux-nix/x86_64 📦tgz
✔️ 2da3be9 #1 2025-02-11 15:15:01 ~23 min windows/x86_64 💿exe
✔️ 14d07eb #2 2025-02-11 16:14:56 ~5 min macos/aarch64 🍎dmg
✔️ 14d07eb #2 2025-02-11 16:17:49 ~8 min tests/nim 📄log
✔️ 14d07eb #2 2025-02-11 16:22:36 ~13 min tests/ui 📄log
✔️ 14d07eb #2 2025-02-11 16:22:57 ~13 min macos/x86_64 🍎dmg
✔️ 14d07eb #2 2025-02-11 16:25:04 ~15 min linux-nix/x86_64 📦tgz
✔️ 14d07eb #2 2025-02-11 16:28:11 ~18 min linux/x86_64 📦tgz
✔️ 14d07eb #2 2025-02-11 16:28:42 ~19 min windows/x86_64 💿exe

Copy link
Contributor

@osmaczko osmaczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants