Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(E2E): Use mouseWheel method to scroll #16487

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

alexjba
Copy link
Contributor

@alexjba alexjba commented Oct 9, 2024

What does the PR do

Closes #16325

This makes the scrolling work for any qml type where the child supports scrolling. By default the cursor is positioned in the middle of the scrollable item and scroll in steps of 30px.
This can be adjusted later on to better fit most of our use cases. It's a configuration we can tweak in an empirical way.

@alexjba alexjba linked an issue Oct 9, 2024 that may be closed by this pull request
@status-im-auto
Copy link
Member

status-im-auto commented Oct 9, 2024

Jenkins Builds

Click to see older builds (9)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 63ed327 #1 2024-10-09 06:49:56 ~6 min macos/aarch64 🍎dmg
✔️ 63ed327 #1 2024-10-09 06:50:15 ~6 min tests/nim 📄log
63ed327 #1 2024-10-09 06:51:52 ~8 min macos/x86_64 📄log
63ed327 #1 2024-10-09 06:54:31 ~10 min tests/ui 📄log
63ed327 #2 2024-10-09 06:56:40 ~4 min macos/x86_64 📄log
✔️ 63ed327 #1 2024-10-09 07:00:07 ~16 min linux-nix/x86_64 📦tgz
✔️ 63ed327 #1 2024-10-09 07:00:55 ~17 min linux/x86_64 📦tgz
✔️ 63ed327 #1 2024-10-09 07:05:32 ~21 min windows/x86_64 💿exe
✔️ 63ed327 #2 2024-10-09 07:14:47 ~12 min tests/ui 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ cf1c9e8 #2 2024-10-10 07:49:27 ~6 min tests/nim 📄log
✔️ cf1c9e8 #2 2024-10-10 07:51:34 ~8 min macos/aarch64 🍎dmg
✔️ cf1c9e8 #3 2024-10-10 07:54:48 ~12 min tests/ui 📄log
✔️ cf1c9e8 #3 2024-10-10 07:56:40 ~13 min macos/x86_64 🍎dmg
✔️ cf1c9e8 #2 2024-10-10 07:56:58 ~14 min linux/x86_64 📦tgz
✔️ cf1c9e8 #2 2024-10-10 08:00:44 ~18 min linux-nix/x86_64 📦tgz
✔️ cf1c9e8 #2 2024-10-10 08:04:48 ~22 min windows/x86_64 💿exe
✔️ c6f8b2a #3 2024-10-10 12:18:25 ~4 min macos/aarch64 🍎dmg
✔️ c6f8b2a #3 2024-10-10 12:21:48 ~7 min tests/nim 📄log
c6f8b2a #4 2024-10-10 12:26:27 ~12 min tests/ui 📄log
✔️ c6f8b2a #4 2024-10-10 12:28:49 ~14 min macos/x86_64 🍎dmg
✔️ c6f8b2a #3 2024-10-10 12:29:55 ~16 min linux-nix/x86_64 📦tgz
✔️ c6f8b2a #3 2024-10-10 12:32:12 ~18 min linux/x86_64 📦tgz
✔️ c6f8b2a #3 2024-10-10 12:32:55 ~18 min windows/x86_64 💿exe
✔️ c6f8b2a #5 2024-10-10 21:16:40 ~11 min tests/ui 📄log

@alexjba alexjba marked this pull request as ready for review October 9, 2024 07:45
@alexjba alexjba requested a review from a team as a code owner October 9, 2024 07:45
@alexjba alexjba requested review from antdanchenko, anastasiyaig and virginiabalducci and removed request for a team October 9, 2024 07:45
@anastasiyaig anastasiyaig force-pushed the 16325-fix-scroll-methods-for-e2e-tests branch from 63ed327 to cf1c9e8 Compare October 10, 2024 07:42
@alexjba alexjba requested a review from caybro October 10, 2024 11:43
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

This makes the scrolling work for any qml type where the child supports scrolling.
By default the cursor is positioned in the middle of the scrollable item and scroll in steps of 30px.
@alexjba alexjba force-pushed the 16325-fix-scroll-methods-for-e2e-tests branch from cf1c9e8 to c6f8b2a Compare October 10, 2024 12:13
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexjba alexjba merged commit 17be3bf into master Oct 11, 2024
9 checks passed
@alexjba alexjba deleted the 16325-fix-scroll-methods-for-e2e-tests branch October 11, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix scroll methods for e2e tests
4 participants