stores: shared/RootStore made not singleton #16449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micieslak
requested review from
caybro,
jrainville,
alexjba and
Khushboo-dev-cpp
Jenkins BuildsClick to see older builds (7)
|
micieslak
force-pushed
the
chore/issue-16247
branch
from
8563395 to
62eb460
Compare
micieslak
force-pushed
the
chore/issue-16247
branch
from
62eb460 to
eb1b422
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
shared/RootStorevia singleton to access via explicit input propertyshared/RootStoreto not-singleton typeRootStorefrom multiple locations)LazyStackLayout(accidentally omitted earlier)Closes: #16247
Affected areas
shared/RootStore, components using that storeArchitecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide