fix: browser connect - send transaction command #16365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saledjenic
requested review from
alaibe,
alexjba,
virginiabalducci and
anastasiyaig
Jenkins BuildsClick to see older builds (6)
|
alexjba
approved these changes
Sep 20, 2024
|
is this PR changing sync code length / UI representation at any point? Sync devices test is failing |
|
i ran the test in the master build commit 894a5f1 and it passes there |
No, had the same failure here #16353 |
|
wonder what's that because i cant reproduce locally there is some change in go #16358 (in this PR tests were passing), maybe it impacts? |
saledjenic
force-pushed
the
fix/issue-16063
branch
from
a8e4408 to
66b2ddb
Compare
saledjenic
force-pushed
the
fix/issue-16063
branch
from
66b2ddb to
f487489
Compare
alaibe
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding
status-goPR:Fixes #16063
Important
Executed swap tx:
Screenshot from the app, where you can see the displayed content in a readable form instead of weird symbols that we had before:
