Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StatusQ] Move StyledTextField to StatusQ #16311

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

caybro
Copy link
Member

@caybro caybro commented Sep 11, 2024

What does the PR do

  • and rename it and its usages to StatusTextField
  • remove a couple of related and unused components

Fixes #16296

Affected areas

Various input fields

Architecture compliance

  • I am familiar with the application architecture and agreed good practices.
    My PR is consistent with this document: Architecture guidelines

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it

PasswordInput:
image

CurrencyAmountInput:
image

AmountToSend (SwapModal):
image

NodeLayout (StatusTextArea & StatusTextField):
image

@caybro caybro linked an issue Sep 11, 2024 that may be closed by this pull request
@status-im-auto
Copy link
Member

status-im-auto commented Sep 11, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 63974b4 #1 2024-09-11 11:58:08 ~6 min macos/aarch64 🍎dmg
✔️ 63974b4 #1 2024-09-11 11:58:58 ~7 min tests/nim 📄log
✔️ 63974b4 #1 2024-09-11 12:01:21 ~9 min macos/x86_64 🍎dmg
63974b4 #1 2024-09-11 12:03:55 ~12 min tests/ui 📄log
✔️ 63974b4 #1 2024-09-11 12:06:25 ~14 min linux-nix/x86_64 📦tgz
✔️ 63974b4 #1 2024-09-11 12:08:41 ~17 min linux/x86_64 📦tgz
✔️ 63974b4 #1 2024-09-11 12:19:17 ~27 min windows/x86_64 💿exe
✔️ 63974b4 #2 2024-09-11 12:25:30 ~11 min tests/ui 📄log
✔️ e3cba88 #2 2024-09-11 12:49:26 ~5 min macos/aarch64 🍎dmg
✔️ e3cba88 #2 2024-09-11 12:50:28 ~6 min tests/nim 📄log
✔️ e3cba88 #2 2024-09-11 12:53:05 ~9 min macos/x86_64 🍎dmg
✔️ e3cba88 #3 2024-09-11 12:55:52 ~11 min tests/ui 📄log
✔️ e3cba88 #2 2024-09-11 12:57:14 ~13 min linux-nix/x86_64 📦tgz
✔️ e3cba88 #2 2024-09-11 13:02:20 ~18 min linux/x86_64 📦tgz
✔️ e3cba88 #2 2024-09-11 13:07:52 ~23 min windows/x86_64 💿exe

- and rename it and its usages to StatusTextField
- remove a couple of related and unused components

Fixes #16296
@caybro caybro force-pushed the 16296-statusq-move-styledtextfield-to-statusq branch from 63974b4 to e3cba88 Compare September 11, 2024 12:43
@caybro caybro marked this pull request as ready for review September 13, 2024 11:04
Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up

Copy link
Member

@micieslak micieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@caybro caybro merged commit 0c6a602 into master Sep 13, 2024
9 checks passed
@caybro caybro deleted the 16296-statusq-move-styledtextfield-to-statusq branch September 13, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[StatusQ] Move StyledTextField to StatusQ
4 participants