fix(StatusSeedPhraseInput): accept a common prefix suggestion #16302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix for a corner case prob when there was a valid seedphrase word (e.g. cat) that is at the same type a prefix for other valid suggestions (e.g. category, catalog, ...); it was imposible to select it using Enter key or mouse click from the suggestions popup at the last field - add a QML regression test for this issue - use standard subcomponents (StatusDropdown, StatusListView) reducing code duplication and unifying UI/UX Fixes #16291
caybro
force-pushed
the
16291-hitting-enter-does-not-fill-in-the-word-on-the-enter-seed-modal-if-the-word-is-3-chars-length-and-it-is-the-last-one
branch
from
74c9ea2 to
4a65df1
Compare
caybro
requested review from
micieslak,
igor-sirotin,
alexjba and
saledjenic
caybro
commented
Sep 9, 2024
| @@ -107,6 +104,7 @@ Item { | |||
| let seedWordTrimmed = seedWord.trim() | |||
| seedWordInput.input.edit.text = seedWordTrimmed | |||
| seedWordInput.input.edit.cursorPosition = seedWordInput.text.length | |||
| filteredList.clear() | |||
There was a problem hiding this comment.
The actual one liner fix :)
Jenkins Builds
|
anastasiyaig
approved these changes
Sep 10, 2024
jrainville
approved these changes
Sep 10, 2024
caybro
deleted the
16291-hitting-enter-does-not-fill-in-the-word-on-the-enter-seed-modal-if-the-word-is-3-chars-length-and-it-is-the-last-one
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #16291
Affected areas
StatusSeedPhraseInput
Architecture compliance
My PR is consistent with this document: Architecture guidelines
Screenshot of functionality (including design for comparison)
Zaznam.obrazovky.z.2024-09-09.23-19-15.mp4