feat(@desktop/wallet): Swap:: Added text that links to Paraswaps terms and conditions page #16035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khushboo-dev-cpp
requested review from
dlipicar,
alexjba and
caybro
and removed request for
dlipicar,
alexjba and
caybro
Jenkins Builds
|
caybro
reviewed
Aug 8, 2024
…s and conditions page
Khushboo-dev-cpp
force-pushed
the
feat/AddParaswapTandCUrlText
branch
from
007387a to
cea0859
Compare
dlipicar
approved these changes
Aug 8, 2024
✔️ status-desktop/prs/macos/aarch64/package/PR-16035#2 🔹 ~8 min 8 sec 🔹 cea0859 🔹 📦 macos/aarch64 package |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Implements new design https://www.figma.com/design/TS0eQX9dAZXqZtELiwKIoK/Swap---Milestone-1?node-id=6187-84605&m=dev
Affected areas
SwapSignModal, SwapApproveModal
StatusQ checklist
Screenshot of functionality (including design for comparison)
Sign flow
https://github.com/user-attachments/assets/0edf9504-f10f-443c-b89b-20dfb4f8006a
Approve flow
https://github.com/user-attachments/assets/156d4af5-68be-4720-a55c-485c24101c00
Cool Spaceship Picture