Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHERRY-PICK] fix(dApps): Improved handling of connected dApps. #15985

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

Seitseman
Copy link
Contributor

Backport of #15877

  1. Hiding DApps button on not supported wallet account selection
  2. Filtering DApps in connected dApps list based on account selection

closes: #15589
closes: #15647

What does the PR do

Affected areas

StatusQ checklist

  • add documentation if necessary (new component, new feature)
  • update sandbox app
    • in case of new component, add new component page
    • in case of new features, add variation to existing component page
    • nice to have: add it to the demo application as well
  • test changes in both light and dark theme?

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it

Cool Spaceship Picture

1. Hiding DApps button on not supported wallet account selection
2. Filtering DApps in connected dApps list based on account selection

closes: #15589
closes: #15647
@status-im-auto
Copy link
Member

status-im-auto commented Aug 5, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e4b2d5e #1 2024-08-05 11:06:54 ~6 min tests/nim 📄log
✔️ e4b2d5e #1 2024-08-05 11:08:02 ~8 min macos/aarch64 🍎dmg
✔️ e4b2d5e #1 2024-08-05 11:11:41 ~11 min macos/x86_64 🍎dmg
✔️ e4b2d5e #1 2024-08-05 11:14:07 ~14 min tests/ui 📄log
✔️ e4b2d5e #1 2024-08-05 11:15:04 ~15 min linux-nix/x86_64 📦tgz
✔️ e4b2d5e #1 2024-08-05 11:16:56 ~16 min linux/x86_64 📦tgz
✔️ e4b2d5e #1 2024-08-05 11:36:38 ~36 min windows/x86_64 💿exe

@Seitseman Seitseman merged commit 6aa6746 into master Aug 5, 2024
9 checks passed
@Seitseman Seitseman deleted the cherry-pick/fix/issue-15647 branch August 5, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants