Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHERRY-PICK] fix(Wallet): Hiding assets from wallet's main view doesn't work #15960

Conversation

caybro
Copy link
Member

@caybro caybro commented Aug 1, 2024

Backport of PR #15811

What does the PR do

  • partially reuse the already available Global/Popups methods to hide assets (which also emit proper notifications); those are needed as anotehr shared modal from Popups uses it too (may come from outside of Wallet)
  • some warnings cleanup in the controller

Fixes #15777

- partially reuse the already available Global/Popups methods to hide
assets (which also emit proper notifications); those are needed as
anotehr shared modal from Popups uses it too (may come from outside of
Wallet)
- some warnings cleanup in the controller

Fixes #15777
@status-im-auto
Copy link
Member

status-im-auto commented Aug 1, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ef74d77 #1 2024-08-01 13:01:58 ~7 min tests/nim 📄log
✔️ ef74d77 #1 2024-08-01 13:02:08 ~7 min macos/aarch64 🍎dmg
✔️ ef74d77 #1 2024-08-01 13:05:10 ~10 min macos/x86_64 🍎dmg
ef74d77 #1 2024-08-01 13:07:10 ~12 min tests/ui 📄log
✔️ ef74d77 #1 2024-08-01 13:11:11 ~16 min linux/x86_64 📦tgz
✔️ ef74d77 #1 2024-08-01 13:11:25 ~17 min linux-nix/x86_64 📦tgz
✔️ ef74d77 #1 2024-08-01 13:19:09 ~24 min windows/x86_64 💿exe
✔️ ef74d77 #2 2024-08-01 13:54:17 ~12 min tests/ui 📄log

@caybro caybro requested a review from Seitseman August 1, 2024 13:02
@jrainville jrainville merged commit cf5b712 into release/2.30.x Aug 2, 2024
9 checks passed
@jrainville jrainville deleted the 15777-wallet-hiding-assets-from-wallets-main-view-doesnt-work-backport branch August 2, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants