chore: new parameters for local pairing #15943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (42)
|
igor-sirotin
force-pushed
the
chore/new-params-pairing
branch
from
f8e97bb to
add9f0c
Compare
saledjenic
approved these changes
Aug 2, 2024
igor-sirotin
changed the title
igor-sirotin
force-pushed
the
chore/new-params-pairing
branch
3 times, most recently
from
a123339 to
4c45451
Compare
igor-sirotin
force-pushed
the
chore/new-params-pairing
branch
from
4c45451 to
0e3ba7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11435
Requires:
This PR finalizes the work done in:
Description
Update
inputConnectionStringForBootstrappingto the new API withCreateAccountDelete
network_constants.nimThis finally removes
NODE_CONFIGandNETWORKSconstants 🎉Remove
getDefaultNodeConfigmethodMake
buildCreateAccountRequestandbuildWalletSecretsfree functionsRemove unused CLI options:
WAKU_V2_PORTSTATUS_PORT