Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@desktop/wallet): SwapModal: refresh currency price as well when fetching proposal #15752

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

Khushboo-dev-cpp
Copy link
Contributor

fixes #15454

status-go PR: status-im/status-go#5564

What does the PR do

Updated currency prices as a way of the current token currency price update mechanism on the nim side

Affected areas

SwapModal

StatusQ checklist

  • add documentation if necessary (new component, new feature)
  • update sandbox app
    • in case of new component, add new component page
    • in case of new features, add variation to existing component page
    • nice to have: add it to the demo application as well
  • test changes in both light and dark theme?

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it
Screen.Recording.2024-07-23.at.7.35.52.PM.mov

Cool Spaceship Picture

@status-im-auto
Copy link
Member

status-im-auto commented Jul 23, 2024

Jenkins Builds

Click to see older builds (60)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9844256 #1 2024-07-23 17:44:41 ~6 min macos/aarch64 🍎dmg
✔️ 9844256 #1 2024-07-23 17:45:55 ~8 min tests/nim 📄log
9844256 #1 2024-07-23 17:50:11 ~12 min tests/ui 📄log
✔️ 9844256 #1 2024-07-23 17:53:12 ~15 min macos/x86_64 🍎dmg
✔️ 9844256 #1 2024-07-23 17:54:46 ~17 min linux-nix/x86_64 📦tgz
✔️ 9844256 #1 2024-07-23 17:55:26 ~17 min linux/x86_64 📦tgz
✔️ 9844256 #1 2024-07-23 18:04:04 ~26 min windows/x86_64 💿exe
6ddaa2e #2 2024-08-16 11:16:39 ~3 min macos/aarch64 📄log
✔️ 6ddaa2e #2 2024-08-16 11:20:08 ~6 min tests/nim 📄log
6ddaa2e #2 2024-08-16 11:22:06 ~8 min macos/x86_64 📄log
6ddaa2e #2 2024-08-16 11:22:25 ~9 min linux/x86_64 📄log
6ddaa2e #2 2024-08-16 11:23:55 ~10 min linux-nix/x86_64 📄log
6ddaa2e #2 2024-08-16 11:27:37 ~14 min tests/ui 📄log
✔️ f7666af #3 2024-08-16 11:33:20 ~4 min macos/aarch64 🍎dmg
✔️ f7666af #3 2024-08-16 11:35:53 ~6 min tests/nim 📄log
✔️ f7666af #3 2024-08-16 11:40:02 ~10 min macos/x86_64 🍎dmg
f7666af #3 2024-08-16 11:41:51 ~12 min tests/ui 📄log
✔️ f7666af #3 2024-08-16 11:43:24 ~14 min linux-nix/x86_64 📦tgz
✔️ f7666af #3 2024-08-16 11:45:20 ~16 min linux/x86_64 📦tgz
✔️ f7666af #3 2024-08-16 12:03:19 ~33 min windows/x86_64 💿exe
✔️ 83750e4 #5 2024-09-06 11:46:54 ~6 min tests/nim 📄log
✔️ 83750e4 #5 2024-09-06 11:49:44 ~9 min macos/aarch64 🍎dmg
83750e4 #5 2024-09-06 11:51:17 ~10 min tests/ui 📄log
✔️ 760d06e #7 2024-09-06 12:03:21 ~6 min macos/aarch64 🍎dmg
✔️ 760d06e #7 2024-09-06 12:03:50 ~6 min tests/nim 📄log
✔️ 760d06e #7 2024-09-06 12:07:50 ~10 min macos/x86_64 🍎dmg
760d06e #7 2024-09-06 12:08:45 ~11 min tests/ui 📄log
✔️ 760d06e #7 2024-09-06 12:12:41 ~15 min linux/x86_64 📦tgz
✔️ 760d06e #7 2024-09-06 12:12:51 ~15 min linux-nix/x86_64 📦tgz
✔️ 760d06e #7 2024-09-06 12:18:07 ~20 min windows/x86_64 💿exe
✔️ 965427e #8 2024-09-09 09:59:56 ~5 min macos/aarch64 🍎dmg
✔️ 965427e #8 2024-09-09 10:01:17 ~7 min tests/nim 📄log
✔️ 965427e #8 2024-09-09 10:05:07 ~10 min macos/x86_64 🍎dmg
965427e #8 2024-09-09 10:05:41 ~11 min tests/ui 📄log
✔️ 965427e #8 2024-09-09 10:06:12 ~12 min linux-nix/x86_64 📦tgz
✔️ 965427e #8 2024-09-09 10:09:17 ~15 min linux/x86_64 📦tgz
769f706 #9 2024-09-09 14:00:13 ~5 min macos/aarch64 📄log
✔️ 769f706 #9 2024-09-09 14:01:00 ~6 min tests/nim 📄log
✔️ 769f706 #9 2024-09-09 14:05:05 ~10 min macos/x86_64 🍎dmg
769f706 #9 2024-09-09 14:06:03 ~11 min tests/ui 📄log
✔️ 769f706 #9 2024-09-09 14:06:42 ~12 min linux-nix/x86_64 📦tgz
✔️ 769f706 #9 2024-09-09 14:08:31 ~14 min linux/x86_64 📦tgz
✔️ 82e94d7 #11 2024-09-10 08:38:18 ~4 min tests/nim 📄log
✔️ 82e94d7 #11 2024-09-10 08:42:24 ~8 min macos/aarch64 🍎dmg
82e94d7 #11 2024-09-10 08:43:14 ~9 min tests/ui 📄log
✔️ 82e94d7 #11 2024-09-10 08:44:44 ~11 min macos/x86_64 🍎dmg
✔️ 82e94d7 #11 2024-09-10 08:46:08 ~12 min linux-nix/x86_64 📦tgz
✔️ 82e94d7 #11 2024-09-10 08:50:16 ~16 min linux/x86_64 📦tgz
✔️ 46025e3 #12 2024-09-10 09:02:21 ~6 min tests/nim 📄log
✔️ 46025e3 #12 2024-09-10 09:02:25 ~6 min macos/aarch64 🍎dmg
✔️ 46025e3 #12 2024-09-10 09:06:38 ~10 min macos/x86_64 🍎dmg
✔️ 46025e3 #12 2024-09-10 09:08:02 ~12 min linux-nix/x86_64 📦tgz
✔️ 46025e3 #12 2024-09-10 09:08:17 ~12 min tests/ui 📄log
✔️ 46025e3 #12 2024-09-10 09:10:21 ~14 min linux/x86_64 📦tgz
✔️ 46025e3 #13 2024-09-11 12:49:16 ~5 min macos/aarch64 🍎dmg
✔️ 46025e3 #13 2024-09-11 12:50:13 ~6 min tests/nim 📄log
✔️ 46025e3 #13 2024-09-11 12:54:23 ~10 min macos/x86_64 🍎dmg
✔️ 46025e3 #13 2024-09-11 12:55:37 ~11 min tests/ui 📄log
✔️ 46025e3 #13 2024-09-11 12:58:41 ~15 min linux-nix/x86_64 📦tgz
✔️ 46025e3 #13 2024-09-11 12:59:30 ~15 min linux/x86_64 📦tgz
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8731402 #14 2024-09-11 13:29:13 ~6 min tests/nim 📄log
✔️ 8731402 #14 2024-09-11 13:29:30 ~7 min macos/aarch64 🍎dmg
✔️ 8731402 #14 2024-09-11 13:32:18 ~9 min macos/x86_64 🍎dmg
8731402 #14 2024-09-11 13:34:04 ~11 min tests/ui 📄log
✔️ 8731402 #14 2024-09-11 13:35:05 ~12 min linux-nix/x86_64 📦tgz
✔️ 8731402 #14 2024-09-11 13:37:53 ~15 min linux/x86_64 📦tgz
✔️ 96a5a46 #15 2024-09-11 15:14:26 ~6 min tests/nim 📄log
✔️ 96a5a46 #15 2024-09-11 15:18:45 ~11 min macos/x86_64 🍎dmg
✔️ 96a5a46 #15 2024-09-11 15:20:31 ~12 min tests/ui 📄log
✔️ 96a5a46 #15 2024-09-11 15:21:52 ~14 min linux-nix/x86_64 📦tgz
✔️ 96a5a46 #15 2024-09-11 15:23:25 ~15 min linux/x86_64 📦tgz
✔️ 96a5a46 #15 2024-09-11 15:33:31 ~25 min macos/aarch64 🍎dmg

@Khushboo-dev-cpp Khushboo-dev-cpp force-pushed the feat/15454 branch 2 times, most recently from 6ddaa2e to f7666af Compare August 16, 2024 11:29
@Khushboo-dev-cpp Khushboo-dev-cpp changed the base branch from master to router-handling-cleaning-changes September 6, 2024 11:40
@Khushboo-dev-cpp Khushboo-dev-cpp force-pushed the feat/15454 branch 3 times, most recently from 760d06e to 965427e Compare September 9, 2024 09:53
@Khushboo-dev-cpp Khushboo-dev-cpp marked this pull request as ready for review September 9, 2024 09:53
@status-im-auto
Copy link
Member

@status-im-auto
Copy link
Member

@saledjenic saledjenic force-pushed the router-handling-cleaning-changes branch from 23e76d4 to 319b3b0 Compare September 10, 2024 07:43
@Khushboo-dev-cpp Khushboo-dev-cpp force-pushed the feat/15454 branch 2 times, most recently from bea8efa to 82e94d7 Compare September 10, 2024 08:33
@status-im-auto
Copy link
Member

@saledjenic saledjenic force-pushed the router-handling-cleaning-changes branch from 319b3b0 to 3a71a00 Compare September 11, 2024 11:54
Base automatically changed from router-handling-cleaning-changes to master September 11, 2024 12:43
@status-im-auto
Copy link
Member

@status-im-auto
Copy link
Member

@status-im-auto
Copy link
Member

@Khushboo-dev-cpp Khushboo-dev-cpp merged commit 8dc067e into master Sep 12, 2024
9 checks passed
@Khushboo-dev-cpp Khushboo-dev-cpp deleted the feat/15454 branch September 12, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SwapModal: refresh currency price as well when fetching proposal
6 participants