Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dApps - Rarible description does not match the modal size (sign message confirmation modal) #15884

Closed
anastasiyaig opened this issue Jul 30, 2024 · 0 comments · Fixed by #15889
Closed

dApps - Rarible description does not match the modal size (sign message confirmation modal) #15884

anastasiyaig opened this issue Jul 30, 2024 · 0 comments · Fixed by #15889
Assignees
@caybro
Labels
bug Something isn't working dapp-interactions
Milestone
2.30.0 Beta

Comments

@anastasiyaig
Copy link
Contributor

Description

Screenshot 2024-07-30 at 11 41 47

Version: 2.30 RC2
@anastasiyaig anastasiyaig added bug Something isn't working dapp-interactions labels Jul 30, 2024
@anastasiyaig anastasiyaig added this to the 2.30.0 Beta milestone Jul 30, 2024
@anastasiyaig anastasiyaig moved this to Iteration Backlog in Status Desktop/Mobile Board Jul 30, 2024
@anastasiyaig anastasiyaig changed the title dApps - Rarible description does not match the modal size dApps - Rarible description does not match the modal size (sign message confirmation modal) Jul 30, 2024
@caybro caybro self-assigned this Jul 30, 2024
@caybro caybro moved this from Iteration Backlog to In Progress in Status Desktop/Mobile Board Jul 30, 2024
@caybro caybro linked a pull request Jul 30, 2024 that will close this issue
fix(ConnectDAppModal): don't overflow texts #15889
Merged
1 task
@caybro caybro moved this from In Progress to Code Review in Status Desktop/Mobile Board Jul 30, 2024
stefandunca added a commit that referenced this issue Jul 30, 2024
@stefandunca
fix(dapps) bad error from status-go api for WalletConnect
d2fa9c3 
Also don't allow undefined values to be passed by addresses. I found
and intermittent issue of not having any account selected. I could not
reproduce it anymore but the logs showed reporting `undefined` values
for addresses. Tracing back the code path I found a potential error if
the lookup of addresses failed and don't allow injecting `undefined`.

Updates: #15884, #15815
@stefandunca stefandunca mentioned this issue Jul 30, 2024
Closed
@github-project-automation github-project-automation bot moved this from Code Review to Done in Status Desktop/Mobile Board Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caybro caybro

Labels
bug Something isn't working dapp-interactions
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
2.30.0 Beta
Development

Successfully merging a pull request may close this issue.

fix(ConnectDAppModal): don't overflow texts status-im/status-desktop
2 participants
@caybro @anastasiyaig