initial attestation aggregation #769
Conversation
|
The epoch boundary condition, especially, is fixed. This is plausibly mergeable now. Testing this is still challenging due to the BLS dependency. |
beacon_chain/beacon_node.nim
Outdated
|
|
||
| let bs = BlockSlot(blck: head, slot: slot) | ||
|
|
||
| let committees_per_slot = get_committee_count_at_slot(state, head.slot) |
There was a problem hiding this comment.
this looks fishy - why head.slot here? what if no blocks have been produced for an epoch or two?
There was a problem hiding this comment.
Yeah, head.slot is incorrect. The idea is here is to be internally consistently living in the recent-past-slots (including committee assignments, numbers of committees, et cetera), as that's the world relative to which the attestation's being aggregated (not head, not the current justified slot/epoch, and not the current finalized slot/epoch, and not the current wall slot).
Which slot that exactly is given by the parameter slot. It probably hasn't made any difference in my local testnet/eth2_network_simulation runs, but obviously matters in a live network.
tersec
force-pushed
the
ati
branch
2 times, most recently
from
fbd05ed to
60992ea
Compare
tersec
force-pushed
the
ati
branch
2 times, most recently
from
5d814b6 to
043c609
Compare
|
This depends on some block pool changes in #812 to be merged to complete. |
…ailing/following distance; document how the only-broadcast-if mechanism works better and what aggregation already happens, not otherwise sufficiently clear; use correct BlockSlot across epoch boundaries
…te broadcast; follow 0.11.x aggregate broadcast p2p interface topic
…d genesis_validators_root
This version finalizes with
make eth2_network_simulation.It fills in the remaining part of #721 almost as much as feasible currently, though, given that https://github.com/status-im/nim-beacon-chain/blob/devel/beacon_chain/spec/crypto.nim (where the BLS signing would be from) is still basically the 0.9.x version.
Finalizes under
make eth2_network_simulationand local testnet locally.