replace unmaintained chip-input lib #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/stateful/vscode-marquee/GDLyom89JtEpCpbsZtPFHwiEd8uK [Deployment for 6ef1b43 canceled] |
|
MUI noob here: what's the best way to prevent the label-adornment overlap from happening? Any advice @christian-bromann ?
|
MoSattler
force-pushed
the
replace-chip=input
branch
from
b14c6ef to
cb5982c
Compare
MoSattler
force-pushed
the
replace-chip=input
branch
from
d9117b0 to
79e44cb
Compare
MoSattler
commented
Mar 16, 2022
|
|
||
| const tagToRemove = screen.getByRole("button", { name: tagToRemoveLabel }); | ||
|
|
||
| userEvent.click(tagToRemove.querySelector("svg")!); |
There was a problem hiding this comment.
Unfortunately the MUI Chip (and MUI generally) has not the greatest a11y (as they admit themselves), which makes it also harder to test at times. So I have to directly address the svg tag.
Interestingly in their own tag, they swap out the default delete icon to test it.
MoSattler
force-pushed
the
replace-chip=input
branch
from
79e44cb to
f456ac3
Compare
MoSattler
force-pushed
the
replace-chip=input
branch
from
ea4245a to
db23a4b
Compare
MoSattler
force-pushed
the
replace-chip=input
branch
from
db23a4b to
14608ee
Compare
MoSattler
force-pushed
the
replace-chip=input
branch
from
14608ee to
e4f2f55
Compare
MoSattler
force-pushed
the
replace-chip=input
branch
from
e4f2f55 to
ebaff76
Compare
MoSattler
force-pushed
the
replace-chip=input
branch
from
ebaff76 to
a4ff293
Compare
MoSattler
force-pushed
the
replace-chip=input
branch
from
a4ff293 to
6ef1b43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #45 (comment)