Improvise error reporting mechanism of cache_filters module #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I've made load data functions to throw more accurate errors about the missing cache data. The several changes I made are:
df_from_votable()
into the functions that were using it:load_filter_index()
&load_transmission_data()
to customize error-checking as per need of caller function.load_transmission_data()
, absence of filter data file is not enough to decide filter_id doesn't index, but it should also be absent from index - for the cases when download of filter data left incomplete.download_transmission_data()
to let users specifically download the missing filter data. Hence code to download transmission data indownload_filter_data()
is also wrapped in this new function.download_transmission_data()
i.e. a part of complete downloading function:download_filter_data()
This is essential for the use of
cache_filters
module both independently and for general purpose, like inbase.py