Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BAppToken functions and FastFeeUpdate #18

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

riccardo-ssvlabs
Copy link
Contributor

  • Test improvements
  • Move from Upg. to non Upg.
  • Achieve 100% Test Coverage

@riccardo-ssvlabs riccardo-ssvlabs marked this pull request as ready for review March 7, 2025 09:31
Copy link

github-actions bot commented Mar 7, 2025

Changes to gas cost

Generated at commit: 5d27f612d3ab96da7b9875c9819fbd56223dbdb0, compared to commit: a4f502e4784da839105768aa50dea5b0e378cf92

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
SSVBasedApps finalizeBAppTokensUpdate
proposeBAppTokensRemoval
proposeBAppTokensUpdate
proposeWithdrawal
updateDelegatedBalance
+14,257 ❌
+61,497 ❌
+58,020 ❌
-3,861 ✅
+1,331 ❌
+423.43%
+1379.17%
+1229.24%
-23.58%
+24.38%
NonCompliantBApp registerBApp -20,172 ✅ -35.47%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
SSVBasedApps 4,309,269 (-17,195) FEE_EXPIRE_TIME
FEE_TIMELOCK_PERIOD
MAX_PERCENTAGE
OBLIGATION_EXPIRE_TIME
OBLIGATION_TIMELOCK_PERIOD
WITHDRAWAL_EXPIRE_TIME
WITHDRAWAL_TIMELOCK_PERIOD
_isBApp
accountBAppStrategy
addTokensToBApp
createObligation
createStrategy
delegateBalance
delegations
depositERC20
depositETH
fastUpdateObligation
fastWithdrawERC20
fastWithdrawETH
finalizeBAppTokensUpdate
finalizeFeeUpdate
finalizeUpdateObligation
finalizeWithdrawal
finalizeWithdrawalETH
initialize
maxFeeIncrement
obligationRequests
optInToBApp
owner
proposeBAppTokensRemoval
proposeBAppTokensUpdate
proposeFeeUpdate
proposeUpdateObligation
proposeWithdrawal
proposeWithdrawalETH
proxiableUUID
registerBApp
removeDelegatedBalance
strategies
strategyTokenBalances
totalDelegatedPercentage
updateBAppMetadataURI
updateDelegatedBalance
updateStrategyMetadataURI
upgradeToAndCall
usedTokens
withdrawalRequests
865 (+22)
887 (+22)
535 (+22)
1,613 (+44)
667 (+22)
557 (+22)
689 (+22)
6,463 (+44)
4,019 (+44)
3,480 (-3)
4,359 (+44)
904 (+22)
1,284 (+44)
3,887 (+44)
1,673 (+44)
1,926 (+390)
4,337 (+44)
1,607 (+44)
1,817 (+44)
3,411 (+44)
3,272 (+22)
4,165 (+44)
3,503 (+22)
4,074 (+44)
4,003 (+44)
2,617 (+22)
3,399 (+22)
3,623 (+22)
3,133 (+22)
3,313 (-3)
3,854 (+44)
3,748 (+44)
4,073 (+44)
1,525 (+44)
1,647 (+44)
699 (+22)
3,926 (+22)
3,111 (+22)
3,500 (+44)
3,064 (+22)
2,769 (+22)
3,373 (-2,102)
1,020 (+22)
4,429 (+44)
3,660 (+22)
3,287 (+22)
5,806 (+44)
+2.61%
+2.54%
+4.29%
+2.80%
+3.41%
+4.11%
+3.30%
+0.69%
+1.11%
-0.09%
+1.02%
+2.49%
+3.55%
+1.14%
+2.70%
+25.39%
+1.02%
+2.82%
+2.48%
+1.31%
+0.68%
+1.07%
+0.63%
+1.09%
+1.11%
+0.85%
+0.65%
+0.61%
+0.71%
-0.09%
+1.15%
+1.19%
+1.09%
+2.97%
+2.74%
+3.25%
+0.56%
+0.71%
+1.27%
+0.72%
+0.80%
-38.39%
+2.20%
+1.00%
+0.60%
+0.67%
+0.76%
865 (+22)
887 (+22)
535 (+22)
1,613 (+44)
667 (+22)
557 (+22)
689 (+22)
6,463 (+44)
4,019 (+44)
12,983 (-1,611)
38,575 (+3,982)
30,820 (-188)
30,234 (-581)
3,887 (+44)
55,751 (+321)
26,264 (+905)
10,309 (-1,470)
17,113 (-3,520)
7,954 (+44)
17,624 (+14,257)
9,065 (+480)
10,276 (-2,114)
13,475 (-9)
11,762 (+246)
72,435 (+245)
2,617 (+22)
3,399 (+22)
95,535 (-14,909)
3,133 (+22)
65,956 (+61,497)
62,740 (+58,020)
15,400 (-293)
24,204 (+130)
12,512 (-3,861)
47,669 (+2,682)
699 (+22)
60,617 (+1,269)
9,622 (-164)
3,500 (+44)
3,064 (+22)
2,769 (+22)
4,435 (-1,040)
6,790 (+1,331)
5,335 (+44)
7,705 (+33)
3,287 (+22)
5,806 (+44)
+2.61%
+2.54%
+4.29%
+2.80%
+3.41%
+4.11%
+3.30%
+0.69%
+1.11%
-11.04%
+11.51%
-0.61%
-1.89%
+1.14%
+0.58%
+3.57%
-12.48%
-17.06%
+0.56%
+423.43%
+5.59%
-17.06%
-0.07%
+2.14%
+0.34%
+0.85%
+0.65%
-13.50%
+0.71%
+1379.17%
+1229.24%
-1.87%
+0.54%
-23.58%
+5.96%
+3.25%
+2.14%
-1.68%
+1.27%
+0.72%
+0.80%
-19.00%
+24.38%
+0.83%
+0.43%
+0.67%
+0.76%
865 (+22)
887 (+22)
535 (+22)
1,613 (+44)
667 (+22)
557 (+22)
689 (+22)
6,463 (+44)
4,019 (+44)
3,905 (+24)
56,687 (+23,082)
30,845 (-204)
48,126 (-316)
3,887 (+44)
66,588 (+44)
26,751 (+597)
8,763 (+44)
5,117 (-30,116)
5,299 (+44)
5,780 (+2,413)
5,515 (-48)
6,510 (-26)
3,692 (-6)
4,312 (-26)
73,419 (+6)
2,617 (+22)
3,399 (+22)
99,585 (-17,099)
3,133 (+22)
75,020 (+71,402)
6,902 (+2,883)
6,246 (+44)
33,467 (+44)
3,921 (+44)
50,659 (+44)
699 (+22)
54,506 (-517)
12,878 (-257)
3,500 (+44)
3,064 (+22)
2,769 (+22)
4,435 (-1,040)
4,480 (+1,136)
5,335 (+44)
7,705 (+33)
3,287 (+22)
5,806 (+44)
+2.61%
+2.54%
+4.29%
+2.80%
+3.41%
+4.11%
+3.30%
+0.69%
+1.11%
+0.62%
+68.69%
-0.66%
-0.65%
+1.14%
+0.07%
+2.28%
+0.50%
-85.48%
+0.84%
+71.67%
-0.86%
-0.40%
-0.16%
-0.60%
+0.01%
+0.85%
+0.65%
-14.65%
+0.71%
+1973.52%
+71.73%
+0.71%
+0.13%
+1.13%
+0.09%
+3.25%
-0.94%
-1.96%
+1.27%
+0.72%
+0.80%
-19.00%
+33.97%
+0.83%
+0.43%
+0.67%
+0.76%
865 (+22)
887 (+22)
535 (+22)
1,613 (+44)
667 (+22)
557 (+22)
689 (+22)
6,463 (+44)
4,019 (+44)
54,252 (-1,062)
56,687 (+44)
30,845 (-204)
48,126 (-316)
3,887 (+44)
66,588 (+44)
26,751 (+597)
38,271 (+44)
35,277 (+44)
19,401 (+44)
39,014 (+35,647)
13,938 (-44)
40,582 (-22)
43,016 (-44)
27,529 (-22)
73,419 (+6)
2,617 (+22)
3,399 (+22)
152,427 (-17,198)
3,133 (+22)
176,116 (+169,671)
124,304 (+117,273)
30,548 (+44)
33,467 (+44)
50,570 (+44)
50,659 (+44)
699 (+22)
150,420 (-2,693)
12,878 (-257)
3,500 (+44)
3,064 (+22)
2,769 (+22)
5,497 (+22)
13,717 (-176)
6,241 (+44)
11,751 (+44)
3,287 (+22)
5,806 (+44)
+2.61%
+2.54%
+4.29%
+2.80%
+3.41%
+4.11%
+3.30%
+0.69%
+1.11%
-1.92%
+0.08%
-0.66%
-0.65%
+1.14%
+0.07%
+2.28%
+0.12%
+0.12%
+0.23%
+1058.72%
-0.31%
-0.05%
-0.10%
-0.08%
+0.01%
+0.85%
+0.65%
-10.14%
+0.71%
+2632.60%
+1667.94%
+0.14%
+0.13%
+0.09%
+0.09%
+3.25%
-1.76%
-1.96%
+1.27%
+0.72%
+0.80%
+0.40%
-1.27%
+0.71%
+0.38%
+0.67%
+0.76%
20 (+10)
22 (+10)
470 (+208)
13 (+5)
37 (+15)
11 (+5)
33 (+15)
2 (0)
276 (+118)
37 (+27)
28 (+5)
1,246 (+492)
95 (+41)
74 (+31)
77 (+25)
51 (+20)
28 (+10)
26 (+5)
4 (0)
32 (+30)
23 (+10)
28 (+10)
4 (0)
31 (+15)
241 (+47)
247 (+52)
29 (+10)
293 (+126)
1 (0)
54 (+48)
62 (+54)
53 (+25)
41 (+15)
16 (+5)
32 (+15)
1 (0)
1,053 (+834)
3 (0)
937 (+381)
242 (+90)
50 (+21)
12 (+10)
6 (+1)
2 (0)
2 (0)
310 (+127)
44 (+20)
NonCompliantBApp 367,716 (0) registerBApp 36,701 (-20,172) -35.47% 36,701 (-20,172) -35.47% 36,701 (-20,172) -35.47% 36,701 (-20,172) -35.47% 2 (0)
WhitelistExample 776,498 (-57,058) addWhitelisted
isWhitelisted
removeWhitelisted
23,777 (-28)
2,505 (-81)
22,198 (-94)
-0.12%
-3.13%
-0.42%
37,242 (+3,182)
2,505 (-81)
23,074 (-86)
+9.34%
-3.13%
-0.37%
43,971 (+9,859)
2,505 (-81)
23,074 (-86)
+28.90%
-3.13%
-0.37%
43,971 (-243)
2,505 (-81)
23,950 (-79)
-0.55%
-3.13%
-0.33%
6 (+2)
5 (+2)
2 (0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant