Revert mono/.NET Framework integration tests #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok but note that Xamarin is now EOL, so it also may not be worth your time. And sockets can't run in the browser so mono/WebAssembly is not relevant to us - I don't think there are any officially supported, commonly used scenarios under mono which are relevant to us |
WojciechNagorski
approved these changes
Aug 4, 2024
|
Can we keep Ecdh and Zlib? We need to make sure .NET Framework specific code to be tested. We don't need to worry about ChaCha20Poly1305 as there's no .NET Framework specific code for it. It is covered by .NET 8.0 integration test. |
|
If it doesn't cause any issues, then fine. I'll try it on the DSA branch. Otherwise it is easy enough to run them properly locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combination is not a worthwhile use of time
Ref #1458 (comment) and #1456