Skip to content
This repository was archived by the owner on Jan 25, 2024. It is now read-only.

Handle ruggeduino occasionally returning spurious bytes #829

Merged
merged 5 commits into from
Oct 14, 2022
Merged

Handle ruggeduino occasionally returning spurious bytes #829

merged 5 commits into from
Oct 14, 2022

Conversation

WillB97
Copy link
Contributor

@WillB97 WillB97 commented Oct 14, 2022

Checklist

  • I have updated the relevant documentation
  • I have added the semver-major, semver-minor or semver-patch label as appropriate
  • I would like multiple reviewers to approve my code before merging

Why do you want to make these changes?

The ruggeduino occasionally returns "\xFF" when first queried which can't be converted to unicode, so throws a UnicodeDecodeError during discovery.

Which parts of the codebase do your changes affect?

Serial devices.

How do your changes affect student or volunteer experience?

Are your changes related to any existing issues or PRs? How so?

Co-authored-by: James Seden Smith <sedders123@gmail.com>
@codeclimate
Copy link

codeclimate bot commented Oct 14, 2022

Code Climate has analyzed commit 8346b4f and detected 0 issues on this pull request.

View more on Code Climate.

@sedders123 sedders123 merged commit d36e1f5 into srobo:main Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants