Skip to content
This repository was archived by the owner on Jan 25, 2024. It is now read-only.

Add support for SRv4 Power Board Serial Interface #812

Merged
merged 33 commits into from
Sep 22, 2022

Conversation

raccube
Copy link
Member

@raccube raccube commented Aug 28, 2022

Checklist

  • I have updated the relevant documentation
  • I have added the semver-major, semver-minor or semver-patch label as appropriate
  • I would like multiple reviewers to approve my code before merging

Why do you want to make these changes?

The new SR Power Board firmware uses a new serial protocol for communication with the power board.

Which parts of the codebase do your changes affect?

SR v4 Power Board. This is not yet fully integrated as we need to detect which PowerBoard class to use based on firmware version.

How do your changes affect student or volunteer experience?

Once fully integrated, this will allow use of updated power boards.

Are your changes related to any existing issues or PRs? How so?

Part of #809

Co-authored-by: Dan Trickey <git@trickey.io>
@raccube raccube changed the title Add base for SRv4 Serial Interface support Add support for SRv4 Power Board Serial Interfac Aug 28, 2022
@raccube raccube changed the title Add support for SRv4 Power Board Serial Interfac Add support for SRv4 Power Board Serial Interface Aug 28, 2022
@trickeydan trickeydan mentioned this pull request Aug 29, 2022
5 tasks
@raccube raccube force-pushed the sr-power-board-serial-fw-support branch from 827cc89 to d812bb4 Compare August 30, 2022 18:01
@raccube raccube force-pushed the sr-power-board-serial-fw-support branch from d812bb4 to c3989df Compare August 31, 2022 19:37
@raccube raccube force-pushed the sr-power-board-serial-fw-support branch from c3989df to bd843b7 Compare August 31, 2022 21:03
@raccube raccube marked this pull request as ready for review September 1, 2022 19:56
@sedders123 sedders123 added the semver-minor This change requires an increment in the minor version number label Sep 1, 2022
Copy link
Contributor

@WillB97 WillB97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly there, still has a few bits to sort out.

@trickeydan trickeydan requested review from WillB97 and removed request for 8BitJosh September 6, 2022 19:27
Copy link
Contributor

@trickeydan trickeydan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 🎉

I'd like to wait until @WillB97 or @8BitJosh approves before merging this too.

@trickeydan trickeydan force-pushed the sr-power-board-serial-fw-support branch from bf44d22 to b90a0f7 Compare September 11, 2022 12:35
@codeclimate
Copy link

codeclimate bot commented Sep 11, 2022

Code Climate has analyzed commit b90a0f7 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@trickeydan trickeydan requested review from WillB97 and removed request for 8BitJosh September 15, 2022 17:10
@trickeydan
Copy link
Contributor

Fixes #816

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
semver-minor This change requires an increment in the minor version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants