This repository was archived by the owner on Jan 25, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 4
Add support for SRv4 Power Board Serial Interface #812
Merged
trickeydan
merged 33 commits into
srobo:main
from
raccube:sr-power-board-serial-fw-support
Sep 22, 2022
Merged
Add support for SRv4 Power Board Serial Interface #812
trickeydan
merged 33 commits into
srobo:main
from
raccube:sr-power-board-serial-fw-support
Sep 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dan Trickey <git@trickey.io>
5 tasks
8BitJosh
reviewed
Aug 29, 2022
8BitJosh
reviewed
Aug 29, 2022
8BitJosh
reviewed
Aug 29, 2022
827cc89
to
d812bb4
Compare
d812bb4
to
c3989df
Compare
c3989df
to
bd843b7
Compare
WillB97
reviewed
Sep 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly there, still has a few bits to sort out.
trickeydan
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WillB97
reviewed
Sep 6, 2022
bf44d22
to
b90a0f7
Compare
Code Climate has analyzed commit b90a0f7 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
WillB97
reviewed
Sep 13, 2022
Fixes #816 |
WillB97
reviewed
Sep 15, 2022
Bumps [pytest](https://github.com/pytest-dev/pytest) from 7.1.2 to 7.1.3. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@7.1.2...7.1.3) --- updated-dependencies: - dependency-name: pytest dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
semver-major
,semver-minor
orsemver-patch
label as appropriateWhy do you want to make these changes?
The new SR Power Board firmware uses a new serial protocol for communication with the power board.
Which parts of the codebase do your changes affect?
SR v4 Power Board. This is not yet fully integrated as we need to detect which
PowerBoard
class to use based on firmware version.How do your changes affect student or volunteer experience?
Once fully integrated, this will allow use of updated power boards.
Are your changes related to any existing issues or PRs? How so?
Part of #809