Skip to content
This repository was archived by the owner on Jan 25, 2024. It is now read-only.

Add base j5Exception #806

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Add base j5Exception #806

merged 1 commit into from
Aug 5, 2022

Conversation

trickeydan
Copy link
Contributor

Checklist

  • I have updated the relevant documentation
  • I have added the semver-major, semver-minor or semver-patch label as appropriate
  • I would like multiple reviewers to approve my code before merging

Why do you want to make these changes?

See #142, also allows users to catch any of our specific errors.

Which parts of the codebase do your changes affect?

Any custom exception classes that j5 has.

How do your changes affect student or volunteer experience?

allows users to catch any of our specific errors.

Are your changes related to any existing issues or PRs? How so?

Fixes #142

@trickeydan trickeydan added enhancement New feature or request semver-patch This change requires an increment in the patch version number labels Aug 5, 2022
@codeclimate
Copy link

codeclimate bot commented Aug 5, 2022

Code Climate has analyzed commit ecf8fd2 and detected 0 issues on this pull request.

View more on Code Climate.

@trickeydan trickeydan merged commit 07f62a1 into main Aug 5, 2022
@trickeydan trickeydan deleted the dgt/j5-base-exception branch August 5, 2022 20:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request semver-patch This change requires an increment in the patch version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we have a j5BaseException?
1 participant