Skip to content
This repository was archived by the owner on Jan 25, 2024. It is now read-only.

Use a default value for read() if stdin is unavailable #713

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Use a default value for read() if stdin is unavailable #713

merged 2 commits into from
Jun 18, 2021

Conversation

raccube
Copy link
Member

@raccube raccube commented Jun 18, 2021

Checklist

  • I have updated the relevant documentation
  • I have added the semver-major, semver-minor or semver-patch label as appropriate
  • I would like multiple reviewers to approve my code before merging

Why do you want to make these changes?

Running robot code with a console environment in a context where stdin is unavailable (i.e. within Astoria) fails due to an EOFError.

Which parts of the codebase do your changes affect?

The console backend and related tests.

How do your changes affect student or volunteer experience?

These changes make it easier for volunteers to run j5-based APIs without a complete kit.

Are your changes related to any existing issues or PRs? How so?

srobo/sr-robot3#20

@trickeydan trickeydan self-requested a review June 18, 2021 16:55
Copy link
Contributor

@trickeydan trickeydan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Congrats on your first PR to j5!

@trickeydan
Copy link
Contributor

Fixes #20

@trickeydan trickeydan merged commit 8dc5ff3 into srobo:main Jun 18, 2021
@raccube raccube changed the title Kjk/console stdin Use a default value for read() if stdin is unavailable Jun 19, 2021
@trickeydan trickeydan mentioned this pull request Jun 19, 2021
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants