-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR:🚇 Add deployment pipeline step #65
Conversation
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
=======================================
Coverage 87.52% 87.52%
=======================================
Files 12 12
Lines 513 513
=======================================
Hits 449 449
Misses 64 64 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @s-weigand thank you for the help checking ways to automate a little bit the release process!
Checking the workflow changes I guess this depends on a pypi_password
(PyPI token) being defined in the repository secrets, right?
Also, I think we need to update https://github.com/spyder-ide/qtsass/blob/master/RELEASE.md to follow up the changes proposed here (at least removing the duplicated steps that now should be done with Github Actions and adding a note about what happens when the git push --tags
is done, i.e it is the trigger for this new deploy job).
Also, do you think it could be worthy to add some validation step to the generated distributions, like the check you can do with twine check dist/*
?
Edit: Thinking a little bit more, should we instead of using the tag as trigger for this new step use the release
event (so creating a GitHub release)? What do you think?
c35f5bd
to
f86f462
Compare
@dalthviz Yes you need to create a token at PyPI (best would be with project scope) and set the I updated the release instructions in f86f462 to match the new workflow. The If you create a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @s-weigand !
@dalthviz Thanks for the new release 🎉
Hope this makes releasing new versions easier in the future