This repository was archived by the owner on Mar 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Update CredentialPack to use ParsedCredential #39
Merged
Ryanmtate
merged 6 commits into
main
from
skit-573-update-credentialpack-to-use-parsedcredential-kotlin
Oct 15, 2024
Merged
Update CredentialPack to use ParsedCredential #39
Ryanmtate
merged 6 commits into
main
from
skit-573-update-credentialpack-to-use-parsedcredential-kotlin
Oct 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Juliano1612 these |
Converted back to draft, IDE didn't immediately notify me of all the compilation errors. |
Juliano1612
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
cobward
commented
Oct 8, 2024
cobward
commented
Oct 8, 2024
example/src/main/java/com/spruceid/mobilesdkexample/wallet/GenericCredentialListItem.kt
Outdated
Show resolved
Hide resolved
cobward
commented
Oct 8, 2024
example/src/main/java/com/spruceid/mobilesdkexample/wallet/GenericCredentialListItem.kt
Show resolved
Hide resolved
Ryanmtate
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to merge.
I will add the addSdJwt
method for the cred pack in a follow up PR.
sprucekit-mobile-monorepo bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
This implements only one button with a scanner that can handle: - External URLs: support QR Code with external URLs by redirecting the user to the browser - OID4VP URLs: redirects the user to the oid4vp flow - OID4VCI URLs: redirects the user to the oid4vci flow
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove
BaseCredential
,Mdoc
andW3CVC
types, and updated the demo app.