-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to override Wss4J default values for InclusivePrefixes #1212
Conversation
@free-ice Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@free-ice Thank you for signing the Contributor License Agreement! |
@gregturn Any feedback would be welcome. |
Resolves spring-projects#1214.
I'll be moving to a new client between Feb 2022 and April 2022. If there are any required changes now is the time to make comments since after that time I will not have a way to manually test any requested changes in a meaningful way. |
I commented on this solution 4 years ago and asked for a release. I don't understand why this can't finally be solved. Compatibility has broken down between wss4j 1.5.x and 2.0.x anyway. |
Greg seems to be the only/main contributor to spring-ws and it seems he is just trying to keep the lights on. Doing OSS can really suck if the projects you work on are on your own time AND you don't use the project yourself. That's not to say its not frustrating, since I don't know if I am not doing something I should be to make the enhancement acceptable. The Wss4J team also seems to be down to one developer , but Colm(Wss4j) provides good feedback after gentle prodding, so at least the core framework is on better footing. |
Yes #1239 is similar, so please give this PR a chance and merge it into release 👍 |
@gregturn I no longer have access to the |
Please close, This PR is super ceded by PR #1300 |
This adds the ability to control wss4j's InclusivePrefixes settings.
This sets the defaults to match wss4j defaults.
#75 should be closed since it would have changed the default behavour of spring-ws.
Tests verify changes and I feel some of the test are overkill but I wanted to ensure that there was no reason not to merge this PR.
I have tested these changes in the 2.4.7 branch of spring-ws, and will be upgrading to this version once the change is merged.
Thanks!