-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging #956
Add logging #956
Conversation
849601d
to
9c3bd84
Compare
9c3bd84
to
8f1a61e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @sjohnr.
Please add logs to OidcClientRegistrationAuthenticationProvider
and OidcClientConfigurationAuthenticationProvider
.
Also, for all Filter
's before calling AuthenticationManager.authenticate()
, let's add the log:
if (logger.isTraceEnabled()) {
logger.trace(LogMessage.format("Authenticating %s", authenticationRequest.getClass().getSimpleName()));
}
...work/security/oauth2/server/authorization/oidc/web/OidcClientRegistrationEndpointFilter.java
Outdated
Show resolved
Hide resolved
...work/security/oauth2/server/authorization/oidc/web/OidcClientRegistrationEndpointFilter.java
Outdated
Show resolved
Hide resolved
...ringframework/security/oauth2/server/authorization/web/OAuth2ClientAuthenticationFilter.java
Outdated
Show resolved
Hide resolved
...ringframework/security/oauth2/server/authorization/web/OAuth2ClientAuthenticationFilter.java
Outdated
Show resolved
Hide resolved
.../security/oauth2/server/authorization/authentication/ClientSecretAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
.../security/oauth2/server/authorization/authentication/ClientSecretAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
...auth2/server/authorization/authentication/OAuth2AuthorizationCodeAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
...erver/authorization/authentication/OAuth2AuthorizationCodeRequestAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
...h2/server/authorization/authentication/OAuth2AuthorizationConsentAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
9b99528
to
24b8f43
Compare
24b8f43
to
6ad869d
Compare
Thanks for the PR @sjohnr ! This is now merged. The |
For consistency with Spring Security (best effort), the logs introduced in this PR use the following keywords:
Note: We also use a console color highlighting plugin (GrepConsole) in IntelliJ that looks for keywords in Spring Security logs which the above could be added to. Currently we look for:
Here's an example log file with Spring Security trace enabled:
application.log
Examples:
Closes gh-159