Replace DelegatingAuthenticationConverter with one in Spring Security #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jgrandja
requested changes
Oct 16, 2024
| * @since 0.0.2 | ||
| * @see AuthenticationConverter | ||
| */ | ||
| public final class DelegatingAuthenticationConverter implements AuthenticationConverter { |
There was a problem hiding this comment.
This cannot be removed until 2.0 as it would be a breaking change for a minor.
Instead, please add @Deprecated at the class level and the @deprecated javadoc tag. See applyDefaultSecurity() as an example:
jgrandja
added
type: enhancement
franticticktick
force-pushed
the
auth_converter
branch
from
6f2ecd6 to
9fa7f60
Compare
|
Hi @jgrandja, thanks for your feedback. All your comments have been resolved. |
jgrandja
changed the title
|
Thanks for the update @CrazyParanoid ! This is now merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing DelegatingAuthenticationConverter with a similar one from spring security.