Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated command with environment file #1063

Closed
wants to merge 1 commit into from
Closed

Replace deprecated command with environment file #1063

wants to merge 1 commit into from

Conversation

jongwooo
Copy link
Contributor

@jongwooo jongwooo commented Feb 5, 2023

Signed-off-by: jongwooo jongwooo.han@gmail.com

Description

Resolve #1062

Update continuous-integration-workflow.yml to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow files that use set-output command through the following command:

$ find .github/workflows -name '*.yml' | xargs egrep '\bset-output\b'

AS-IS

run: |
  # Run jobs if in upstream repository
  echo "::set-output name=runjobs::true"
  # Extract version from gradle.properties
  version=$(cat gradle.properties | grep "version=" | awk -F'=' '{print $2}')
  echo "::set-output name=project_version::$version"

TO-BE

run: |
  # Run jobs if in upstream repository
  echo "runjobs=true" >> $GITHUB_OUTPUT
  # Extract version from gradle.properties
  version=$(cat gradle.properties | grep "version=" | awk -F'=' '{print $2}')
  echo "project_version=$version" >> $GITHUB_OUTPUT

Signed-off-by: jongwooo <jongwooo.han@gmail.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 5, 2023
@sjohnr sjohnr self-assigned this Feb 8, 2023
@sjohnr sjohnr added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 8, 2023
@sjohnr
Copy link
Member

sjohnr commented Feb 14, 2023

Thanks @jongwooo! This is merged into 0.4.x via 70fade4 and 1.0.x via f0530e7.

@sjohnr sjohnr closed this Feb 14, 2023
@jongwooo jongwooo deleted the chore/replace-deprecated-command-with-environment-file branch February 14, 2023 16:42
@sjohnr sjohnr added the status: duplicate A duplicate of another issue label Feb 14, 2023
@sjohnr sjohnr added this to the 0.4.1 milestone Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file
3 participants