Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Spring Boot 3.0.0 #1024

Closed
wants to merge 1 commit into from
Closed

Update to Spring Boot 3.0.0 #1024

wants to merge 1 commit into from

Conversation

SamTV12345
Copy link
Contributor

Upgraded examples to the official Spring Boot 3.0.0 dependency.

@SamTV12345
Copy link
Contributor Author

Fixes #1023

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 23, 2022
Copy link
Collaborator

@jgrandja jgrandja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @SamTV12345. Please see review comment.

id "org.springframework.boot" version "3.0.0-RC2"
id "io.spring.dependency-management" version "1.0.11.RELEASE"
id "org.springframework.boot" version "3.0.0"
id "io.spring.dependency-management" version "1.1.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the updates to io.spring.dependency-management. Is the 1.1.0 version required for Spring Boot 3.0.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. I reverted to 1.0.11.RELEASE. I upgraded it because there was a newer version available. Both versions work without a problem.

@jgrandja jgrandja changed the title Upgraded examples to use Spring Boot 3.0.0 Update to Spring Boot 3.0.0 Jan 10, 2023
@jgrandja jgrandja self-assigned this Jan 10, 2023
@jgrandja jgrandja added status: duplicate A duplicate of another issue type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 10, 2023
@jgrandja jgrandja added this to the 1.0.1 milestone Jan 10, 2023
@SamTV12345 SamTV12345 requested a review from jgrandja January 11, 2023 11:59
@jgrandja jgrandja added type: dependency-upgrade A dependency upgrade and removed type: enhancement A general enhancement labels Jan 16, 2023
@jgrandja
Copy link
Collaborator

Thanks for the updates @SamTV12345. This is now merged.

@jgrandja jgrandja closed this Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue type: dependency-upgrade A dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants