Skip to content
This repository was archived by the owner on Feb 23, 2023. It is now read-only.

Auditing Support for Spring Data #892

Merged
merged 2 commits into from
Jul 19, 2021
Merged

Auditing Support for Spring Data #892

merged 2 commits into from
Jul 19, 2021

Conversation

schauder
Copy link
Contributor

@schauder schauder commented Jul 6, 2021

Closes #860
Closes #882

@schauder schauder requested a review from christophstrobl July 6, 2021 14:35
christophstrobl
christophstrobl suggested changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@christophstrobl christophstrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move the common parts of the hints to a dedicated class and pull them in via imports.

Thinking about the types from commons like IsNewAwareAuditingHandler, LazyInitTargetSource and the proxy configuration.

Would help us with the other data modules.

@schauder
Copy link
Contributor Author

schauder commented Jul 7, 2021

Can we move the common parts of the hints to a dedicated class and pull them in via imports.

That's my plan with the next modules, which I want to tackle today.
Sticking to the rule of refactoring, when you have three repetitions.

@sdeleuze
Copy link
Contributor

sdeleuze commented Jul 7, 2021

Ok so I will wait for those changes before merging.

@schauder schauder changed the title Auditing Support for Spring Data JPA and Spring Data R2DBC Auditing Support for Spring Data JPA and Spring Data R2DBC and ElasticSearch Jul 7, 2021
@schauder
Copy link
Contributor Author

schauder commented Jul 7, 2021

With the additional commits we also support Auditing for Elasticsearch. And they include the refactoring to exract common hints to a single place.

@schauder schauder changed the title Auditing Support for Spring Data JPA and Spring Data R2DBC and ElasticSearch Auditing Support for Spring Data Jul 13, 2021
@schauder
Copy link
Contributor Author

This PR now adds Auditing support for all Spring Data samples.

@schauder schauder force-pushed the issue/auditing-support branch from d378945 to 483133a Compare July 13, 2021 11:27
@christophstrobl
Copy link
Contributor

@schauder could you please add license headers to the newly introduced files.

@schauder
Added copyright header.
4c04fcc 
For all new files and touched files without a header.
For touched files with header, the date range is now extended to 2021.
@schauder
Copy link
Contributor Author

@schauder could you please add license headers to the newly introduced files.

@christophstrobl done.

christophstrobl
christophstrobl approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@christophstrobl christophstrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdeleuze sdeleuze merged commit 732cb50 into main Jul 19, 2021
@snicoll snicoll deleted the issue/auditing-support branch August 26, 2021 08:52
@christophstrobl christophstrobl mentioned this pull request Sep 8, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@christophstrobl christophstrobl christophstrobl approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spring Data Audit Not Working Even After 0.10.1 Runtime exception when setting @EnableR2dbcAuditing
3 participants
@schauder @sdeleuze @christophstrobl