This repository was archived by the owner on Feb 23, 2023. It is now read-only.
Refine TypeProcessor - allow scanning TypeSystem without repeating filters. #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lters.
Introduce TypeProcessor.filter and inspection depth to allow filtering candidate Types based on a single filter instead of repeated ones.
The inspection limit, defines the maximum number of hops allowed when inspecting types and their signatures.
Given a structure like below, and a level of 1 the callback would be invoked for Level0, SomeInterface
and Level1, but not for Level2.
When using level 0, the callback is only invoked for Level0.
class Level0 implements SomeInterface {
Level1 level1;
}
class Level1 {
Level2 level2;
}
class Level2 {
// ...
}
Also introduce a DiscoveryContext that provides access to the Path that lead to a certain type. That way type registration callbacks can decide upon more information what to do.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
TypeProcessor.filter(...)andTypeProcessor.limitInspectionDepth(...)to allow filtering candidate Types based on a single filter instead of repeated ones.The inspection depth limit, defines the maximum number of hops allowed during signature traversal.
Given a structure like below, and a limit of
1, the type registration callback is invoked forLevel0,SomeInterfaceand
Level1, but not forLevel2.Setting the limit to
0, the callback is only invoked forLevel0.Along the lines introduce a
DiscoveryContextthat provides access to thePaththat leads to a certain type. That way, type registration callbacks can decide upon more information.