-
Notifications
You must be signed in to change notification settings - Fork 353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commented about one improvement I'd like to see.
@sdeleuze and @christophstrobl The hints kind of duplicate information which is already programmatically encoded in JdbcAuditingRegistrar
, namely the beans required for enabling auditing.
If we don't want to reproduce this for every store we should find a way to extract that information from the constructed bean definitions.
@schauder Could you please have a new look to give me a status for this PR? |
The PR breaks the JDBC sample for me. When I run
For both the PR as it is and for a rebased version on main. Please make sure to run the sample and make sure it works. |
9517373
to
378e73d
Compare
378e73d
to
e9f68bd
Compare
Sorry for that! I was certain I ran example while testing. Looks like I ran it in jvm mode. |
e9f68bd
to
382e9a3
Compare
It still fails for me. |
This is weird. I just rechecked with clean and it works for me. Could you add some more context so I could reproduce it? |
Sorry, that was my mistake. I rebased and squashed this on main and added a little polishing. Thanks. |
Hello spring native contributors!
I'm currently evaluating your work and it looks amazing!
One little feature I found missing is spring-data-jdbc auditing.
I created native hints for it and added usage of it in samples so the support can be easily verified.