This repository was archived by the owner on Feb 23, 2023. It is now read-only.
ImportAware links are being called inconsistently #1079
Comments
snicoll
changed the title
|
On a second look, this is rather a different problem. We're taking the parent configuration class as the import link whereas framework really means the import semantic. So, for instance, if you have a inner class of a configuration class that's import aware, the AOT engine will honor the callback whereas the JVM would not (as the inner class wasn't Unfortunately, there's no API to access that information as the |
snicoll
added a commit
that referenced
this issue
Sep 28, 2021
This commit refines our strategy to invoke ImportAware callbacks to use framework's ImportRegistry rather than running our own logic. At build time, we know requested the importing class of each bean that is import aware, and store that in a registry of our own. This is latter used to write the links that ImportAwareInvoker uses at build time. ImportAwareInvoker has also been refined to not invoke the callback if no import class is registered. Previously, it was throwing an innacurate exception as this is possible for an import aware configuration class to be processed directly (i.e. without a corresponding import arrangement). Closes gh-1079
|
Fixed by 1d055a1 |
snicoll
added a commit
that referenced
this issue
Sep 28, 2021
This commit refines our strategy to invoke ImportAware callbacks to use framework's ImportRegistry rather than running our own logic. At build time, we know requested the importing class of each bean that is import aware, and store that in a registry of our own. This is latter used to write the links that ImportAwareInvoker uses at build time. ImportAwareInvoker has also been refined to not invoke the callback if no import class is registered. Previously, it was throwing an innacurate exception as this is possible for an import aware configuration class to be processed directly (i.e. without a corresponding import arrangement). Closes gh-1079
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
ImportAwareLinksDiscovereris relying onResolvableTypeto figure out whether the bean type implementsImportAware. Unfortunately, some bean definitions doesn't have one so we should fallback to thebeanClassNameif necessary.The text was updated successfully, but these errors were encountered: