refactor: add better logging for invalid or missing client key #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickybondarenko
requested review from
Billlynch,
andreas-karlsson,
fabriziodemaria,
mfranberg,
vahidlazio and
nicklasl
as code owners
nickybondarenko
force-pushed
the
log-invalid-client-key
branch
from
a93737b to
6f63b5b
Compare
nickybondarenko
force-pushed
the
log-invalid-client-key
branch
from
6f63b5b to
f60734a
Compare
Comment on lines
+351
to
+353
| .compose(next => request => { | ||
| return next(request); | ||
| }) |
There was a problem hiding this comment.
This can be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some of the concerns brought up by this issue and adds better logging for missing or invalid client key.