feat(spin): Container improvements, non-root, exec spin, :latest tag #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the principle of least privilege we should not run as root user. There is no need. Match other Spinnaker services and run as a high user id. Additional containers generally run the application process as the entrypoint rather than a shell. This makes performing commands simpler as we can tack on any arguments to the end of the image like so: ``` $ docker run --rm -it spin:latest --version version dev ``` The `VERSION` build arg now defaults to `dev` otherwise an empty VERSION string overwrites default in Go and results in the `--version` flag disappearing.
We have a convention in Spinnaker land of tagging containers with `master-latest-unvalidated`. `master` comes from the branch (master|release-*) and for `master` could potentially be dropped. `unvalidated` is used because of nightly integration tests which haven't been used with `spin` before. All in all push `:latest` tag on successful CI run for master commits. Standard UX in container-land.
kskewes-sf
force-pushed
the
container-user
branch
from
c412fe5 to
6787334
Compare
kskewes-sf
changed the title
mattgogerly
approved these changes
Mar 18, 2022
dbyron-sf
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the principle of least privilege we should not run as root
user. There is no need.
Match other Spinnaker services and run as a high user id.
Additional containers generally run the application process as
the entrypoint rather than a shell.
This makes performing commands simpler as we can tack on any arguments
to the end of the image like so:
The
VERSIONbuild arg now defaults todevotherwise an empty VERSIONstring overwrites default in Go and results in the
--versionflagdisappearing.