fix(web): make type of additionalFilters in ImageController.findImages (backport #1877) #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
#1877) * test(web): demonstrate behavior of ImageController.findImages * fix(web): make type of additionalFilters in ImageController.findImages match what ImageSerice.search expects. Since the test in the previous commit passes without this, apparently it's not required, but it removes an IDE warning, and generally feels like an improvement. (cherry picked from commit 875a8b1)
dbyron-sf
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
match what ImageSerice.search expects. Since the test in the previous commit passes without this, apparently it's not required, but it removes an IDE warning, and generally feels like an improvement.
See #1875 (comment) for background.
This is an automatic backport of pull request #1877 done by [Mergify](https://mergify.com).