feat(taskView): Implement opt-in paginated request for TaskView #10093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovidiupopa07
approved these changes
May 7, 2024
|
@ovidiupopa07 Since this is behind a feature flag and there is no change in the functionality when not used can we backport it to the active releases? |
|
@Mergifyio backport release-1.32.x release-1.33.x release-1.34.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 7, 2024
* feat(tasksview): Allowing opt-in pagination for tasks view loading * feat(taskView): Implement opt-in paginated request for TaskView (cherry picked from commit 5fa1e96) # Conflicts: # yarn.lock
mergify bot
pushed a commit
that referenced
this pull request
May 7, 2024
* feat(tasksview): Allowing opt-in pagination for tasks view loading * feat(taskView): Implement opt-in paginated request for TaskView (cherry picked from commit 5fa1e96)
mergify bot
pushed a commit
that referenced
this pull request
May 7, 2024
* feat(tasksview): Allowing opt-in pagination for tasks view loading * feat(taskView): Implement opt-in paginated request for TaskView (cherry picked from commit 5fa1e96)
This was referenced May 7, 2024
christosarvanitis
added a commit
to armory-io/deck
that referenced
this pull request
May 7, 2024
…naker#10093) * feat(tasksview): Allowing opt-in pagination for tasks view loading * feat(taskView): Implement opt-in paginated request for TaskView (cherry picked from commit 5fa1e96)
ovidiupopa07
pushed a commit
that referenced
this pull request
May 7, 2024
jasonmcintosh
pushed a commit
that referenced
this pull request
May 7, 2024
* feat(taskView): Implement opt-in paginated request for TaskView (#10093) * feat(tasksview): Allowing opt-in pagination for tasks view loading * feat(taskView): Implement opt-in paginated request for TaskView (cherry picked from commit 5fa1e96) * fix(tasksView): Resolving conflicts on yarn.lock backport
mergify bot
added a commit
that referenced
this pull request
May 9, 2024
…port #10093) (#10094) * feat(taskView): Implement opt-in paginated request for TaskView (#10093) * feat(tasksview): Allowing opt-in pagination for tasks view loading * feat(taskView): Implement opt-in paginated request for TaskView (cherry picked from commit 5fa1e96) # Conflicts: # yarn.lock * feat(taskView): Implement opt-in paginated request for TaskView (#10093) (#10098) * feat(tasksview): Allowing opt-in pagination for tasks view loading * feat(taskView): Implement opt-in paginated request for TaskView (cherry picked from commit 5fa1e96) * fix(tasksView): Resolving conflicts on yarn.lock backport (#10099) * feat(taskView): Implement opt-in paginated request for TaskView (#10093) * feat(tasksview): Allowing opt-in pagination for tasks view loading * feat(taskView): Implement opt-in paginated request for TaskView (cherry picked from commit 5fa1e96) * fix(tasksView): Resolving conflicts on yarn.lock backport --------- Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io> Co-authored-by: Jason <jason.mcintosh@armory.io>
sahititarigoppula
pushed a commit
to OpsMx/deck-oes
that referenced
this pull request
Jul 2, 2024
…naker#10093) (spinnaker#10095) * feat(tasksview): Allowing opt-in pagination for tasks view loading * feat(taskView): Implement opt-in paginated request for TaskView (cherry picked from commit 5fa1e96) Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io> Co-authored-by: Jason <jason.mcintosh@armory.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The taskView by default tries to load the full task list (as allowed by the Orca api configuration). However for applications that are heavily used and have a high number of tasks retrieving the full task list in a single request is resulting many times in timeout either because of the backend or because the Deck timeout was reached.
The task controller on the backend supports pagination so this PR attempts to provide the end user control on the max task limit per page to be retrieved from the backend.
The datasource logic doesnt change in the PR - Deck will still consider the taskView as loaded when all the tasks are retrieved but what changes is that by adding the opt-in setting in settings-local.js
on the taskView the single request will be splitted in multiple requests with limit=&page=.
screenRecording.mov