Support unparsing plans after applying optimize_projections rule
#55
+78
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrebnov
commented
Nov 4, 2024
sgrebnov
commented
Nov 4, 2024
phillipleblanc
approved these changes
Nov 4, 2024
peasee
approved these changes
Nov 4, 2024
Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech>
sgrebnov
added a commit
that referenced
this pull request
Nov 5, 2024
phillipleblanc
pushed a commit
that referenced
this pull request
Nov 12, 2024
phillipleblanc
pushed a commit
that referenced
this pull request
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
PR adds support for unparsing plans after
optimization_projectionsis appliedAdded
optimize_projections_preserve_existing_projectionsconfig option to prevent optimization logic to aggressivly create / remove proejctions, as a result optimized plan can look like to following. This makes sense for Datafusion execution logic but not for unparsing use cases.https://gist.github.com/sgrebnov/5071d2834e812b62bfdf434cf7e7e54c
Improved unparsing logic to support TableScans with pushed down projection.