Radial weight vectors in CHT #5
Merged
+46
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Radial weight function (`circ_radial_weights', `circular_pw`, `circular_ls') now returns a vector of length 2*N+1 with N being the maximum modal order * The ordering is consistant with the previous implementation: 0,1,...,N,-N,...-1 * In `circ_diagonal_modal_mat`, mirroring of the radial weights is no longer necessary. So `mirror_vec` will be depricated
* The modal bandwidth of the incident sound field `Nsf` may differ from that of the modal beamforming `N` * For open circular arrays, the incident sound can have either a finite or an infinite modal bandwidth
trettberg
requested changes
Nov 22, 2017
trettberg
approved these changes
Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
circ_radial_weights',circular_pw,circular_ls') now returns a vector of length2*N+1instead ofN+1, withNbeing the maximum modal ordercirc_diagonal_modal_mat, mirroring of the radial weights is no longer necessary. Somirror_vecwill be deprecated