Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EmptyProvider instead of React.Fragment in Provided #1797

Merged
merged 5 commits into from
Jul 12, 2021

Conversation

goran-peoski-work
Copy link
Contributor

In order not to have console errors in browsers when using React.Fragment like in the image,
a default no-operation EmptyProvider wraps children in Provided

sparkle-admin-flashes-03

@goran-peoski-work goran-peoski-work requested a review from a team as a code owner July 12, 2021 11:07
@goran-peoski-work goran-peoski-work temporarily deployed to feature-preview July 12, 2021 11:07 Inactive
@codeclimate
Copy link

codeclimate bot commented Jul 12, 2021

Code Climate has analyzed commit ecbb55d and detected 0 issues on this pull request.

View more on Code Climate.

@goran-peoski-work goran-peoski-work added the 🐛 bug A bug, error, issue, problem, etc within the platform. label Jul 12, 2021
@github-actions
Copy link

github-actions bot commented Jul 12, 2021

Visit the preview URL for this PR (updated for commit 51441e1):

https://co-reality-staging--preview-pr-1797-toyte133.web.app

(expires Mon, 19 Jul 2021 12:02:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Contributor

@0xdevalias 0xdevalias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small fixes (see earlier suggestions) then this should be good to go.

@goran-peoski-work goran-peoski-work enabled auto-merge (squash) July 12, 2021 11:56
@goran-peoski-work goran-peoski-work temporarily deployed to feature-preview July 12, 2021 11:56 Inactive
Co-authored-by: Glenn 'devalias' Grant <glenn@devalias.net>
@goran-peoski-work goran-peoski-work temporarily deployed to feature-preview July 12, 2021 11:58 Inactive
Co-authored-by: Glenn 'devalias' Grant <glenn@devalias.net>
@goran-peoski-work goran-peoski-work temporarily deployed to feature-preview July 12, 2021 11:58 Inactive
@goran-peoski-work goran-peoski-work temporarily deployed to feature-preview July 12, 2021 11:58 Inactive
@goran-peoski-work goran-peoski-work merged commit 398fe4e into staging Jul 12, 2021
@goran-peoski-work goran-peoski-work deleted the fix/empty-provider branch July 12, 2021 12:00
This was referenced Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug A bug, error, issue, problem, etc within the platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants