fix Error: <WorldUsersProvider/> not found in a more holistic way

[goran-peoski-work]

Should fix Error: <WorldUsersProvider/> not found in Admin components that was introduced in #1703. One such issue is Edit Room in Admin v1 panel.

Partial fix to https://github.com/sparkletown/internal-sparkle-issues/issues/886

partially fixes https://github.com/sparkletown/internal-sparkle-issues/issues/839

fixes https://github.com/sparkletown/internal-sparkle-issues/issues/904

fixes https://github.com/sparkletown/internal-sparkle-issues/issues/905

Reverts and supercedes #1757

[codeclimate]

Code Climate has analyzed commit 14c83db and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1
Duplication	2

View more on Code Climate.

[0xdevalias]

We probably don't want to add this in to src/components/organisms/WithNavigationBar/WithNavigationBar.tsx I don't think, but should be wrapping at a higher level (eg. potentially in the admin subrouter, or possibly could be around all of the routes maybe..? Not 100%

[goran-peoski-work]

Possible edge case bug, by @0xdevalias :

because admin lets you jump around between all sorts of venues, not just related venues. And since the venueId is passed into it, and that used to get the sovereign venue, but the sovereign venue cached forever currently, if we switch out of a related venue it will return the wrong users.

OOS for this fix, should be addressed/superseded/rendered moot by latter Admin development PRs

(cc // @mike-lvov FYI)

[goran-peoski-work]

@sofisparkle Ready for review

[0xdevalias]

A tiny cleanup + a question about how it actually works.

Also, can you please check if it’s going to be needed for any of the other routes in AppRouter.

I know for a fact that VenueAdminPage (/in/:venueId/admin) needs it, as that’s the one that broke the banner admin (and it’s not part of the admin subrouter), but I expect there will be other places too.

[github-actions]

Visit the preview URL for this PR (updated for commit 14c83db):

https://co-reality-staging--preview-pr-1769-x4vdat1z.web.app

_{(expires Sat, 17 Jul 2021 10:19:25 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

[goran-peoski-work]

@sofisparkle ready for review

[0xdevalias]

@ermiaSparkle Why did you do this? You shouldn't be merging anything into this branch..

[ermiaSparkle]

@0xdevalias
Soooooooooooooooooo sorry
I was going to apply his changes to mine. not mine to his
:((((((((((((((((((((((((((((((((((((((((((
How can I fix it?

[0xdevalias]

How can I fix it?

@ermiaSparkle I've pulled the branch and rebased it to remove your commits, then force pushed it, so should be fixed now.

[0xdevalias]

LGTM! 🚄