-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move build configuration into pyproject.toml
#1661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a little too early for this. You will need a very new version of pip.
We should wait for several more releases from Python org.
4f15952
to
0d37fc3
Compare
be2ead6
to
a4ea8ce
Compare
0385950
to
def44df
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1661 +/- ##
=======================================
Coverage 91.75% 91.75%
=======================================
Files 147 147
Lines 16186 16186
=======================================
Hits 14852 14852
Misses 1334 1334 ☔ View full report in Codecov by Sentry. |
I resolved the conflicts, let's see if the tests pass this time...I installed in a few environments locally and everything seemed to work fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to kick the tests a couple times, but they finally passed. I pushed one fix to the sphinx config section, I think this is good to go now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Local install works on my end. Installation is successful, can import jdaviz
and the SpecvizExample notebook works great. Thanks for the contribution!
Description
setuptools
now supports the[project]
table, which is defined by PEP621.Additionally,
setuptools
now supports its own entry inpyproject.toml
called[tool.setuptools]
(pypa/setuptools#1688, https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#setuptools-specific-configuration); however, it comes with the following disclaimer:Reading
toml
is supported natively in Python 3.11 withtomllib
Given this, we can attempt to consolidate the build configuration into a single
pyproject.toml
file that can possibly be read by other build systems in the future.Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.