Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error when updating an AWS integration attachment #614

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

adamconnelly
Copy link
Contributor

@adamconnelly adamconnelly commented Mar 6, 2025

Description of the change

The problem is that the field used to store the response from the mutation wasn't exported, causing the struct field for "awsIntegrationAttachmentUpdate" doesn't exist in any of 1 places to unmarshal error.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Chore (maintenance work, dependency bumps, refactors, not supposed to break existing functionalities)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Related issues

Fixes #610

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

The problem is that the field used to store the response from the mutation wasn't exported, causing the `struct field for "awsIntegrationAttachmentUpdate" doesn't exist in any of 1 places to unmarshal` error.

Fixes #610
@adamconnelly adamconnelly requested review from michieldewilde and a team March 6, 2025 11:50
Copy link
Contributor

@peterdeme peterdeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@adamconnelly adamconnelly marked this pull request as ready for review March 6, 2025 12:15
@adamconnelly adamconnelly merged commit ef17b6e into main Mar 6, 2025
7 checks passed
@adamconnelly adamconnelly deleted the adamc/610-fix-aws-integration-attachment-update branch March 6, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spacelift_aws_integration_attachment issues spurious error when updating write parameter from false to true
3 participants