Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs to consider legacy space not being present #551

Merged

Conversation

sephriot
Copy link
Contributor

@sephriot sephriot commented May 9, 2024

Description of the change

Should be merged before: https://github.com/spacelift-io/backend/pull/6925

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

Signed-off-by: Jakub <jakub.wojtowicz@sephcode.pl>
@sephriot sephriot marked this pull request as ready for review May 9, 2024 11:37
Copy link
Contributor

@mwasilew2 mwasilew2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the "how" makes sense, I don't have enough context for the "why" ;)

@sephriot
Copy link
Contributor Author

the "how" makes sense, I don't have enough context for the "why" ;)

The "why" was in the clickup ticket that wasn't linked 😞

@sephriot sephriot merged commit 306b856 into main May 17, 2024
7 checks passed
@sephriot sephriot deleted the CU-862jx0n8q_Remove-legacy-space-for-new-accounts_Jakub-Wjtowicz branch May 17, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants