Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back to using shared workers #157

Merged
merged 3 commits into from
Apr 30, 2021
Merged

Back to using shared workers #157

merged 3 commits into from
Apr 30, 2021

Conversation

marcinwyszynski
Copy link
Contributor

Description of the change

Private workers and public repos don't mix.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

@marcinwyszynski marcinwyszynski added the bug Something isn't working label Apr 30, 2021
@marcinwyszynski marcinwyszynski requested a review from a team April 30, 2021 07:58
@marcinwyszynski marcinwyszynski self-assigned this Apr 30, 2021
@marcinwyszynski marcinwyszynski force-pushed the back-to-shared-workers branch from 3f90236 to 6438165 Compare April 30, 2021 08:16
@marcinwyszynski marcinwyszynski force-pushed the back-to-shared-workers branch from 5588e8a to a3a5451 Compare April 30, 2021 08:29
adamconnelly
adamconnelly approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@adamconnelly adamconnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

spacelift/data_current_stack.go
@@ -22,7 +22,7 @@ func dataCurrentStackRead(d *schema.ResourceData, meta interface{}) error {
if err != nil {
// Don't care about validation errors, we don't actually validate those
// tokens, we only parse them.
if _, isValidation := err.(*jwt.ValidationError); !isValidation {
if !errors.Is(err, &jwt.UnverfiableTokenError{}) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 dgrijalva/jwt-go#448

Once it's seen it can't be un-seen 😆

@marcinwyszynski marcinwyszynski merged commit eabeff9 into future Apr 30, 2021
@marcinwyszynski marcinwyszynski deleted the back-to-shared-workers branch April 30, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamconnelly adamconnelly adamconnelly approved these changes

Assignees

@marcinwyszynski marcinwyszynski

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcinwyszynski @adamconnelly