-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Store and retrieve hash abundances in LCA DBs. #1015
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## protein_lca_db #1015 +/- ##
==================================================
- Coverage 92.33% 92.03% -0.30%
==================================================
Files 72 72
Lines 5413 5439 +26
==================================================
+ Hits 4998 5006 +8
- Misses 415 433 +18
Continue to review full report at Codecov.
|
I'm going to close this for now, as I don't think we actually need it for anything useful :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this is a PR into #1013.
Currently, the LCA/revindex databases cannot store or retrieve hashval abundances, which means that signatures with track_abundances are not represented faithfully. As suggested in #581 (comment), this PR enables abundance storage in
LCA_Database
objects by storing them inhashval_to_idx
values as tuples(idx, abund)
.After #1013, I think this is the last change to
LCA_Database
to bring it into full compliance as a signature storage database, i.e. all inserted signatures can be full reconstructed from the database. w00t!Also see #634 and #1013 for motivation.
TODO:
PR checklist:
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?