fix: Maintain indexes across schema versions #3366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This passes when commenting out the patch, but fails on when including it.
ID changes on every patch, so the indexes were lost.
AndrewSisley
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3366 +/- ##
========================================
Coverage 78.42% 78.42%
========================================
Files 392 392
Lines 35688 35688
========================================
+ Hits 27985 27986 +1
+ Misses 6065 6064 -1
Partials 1638 1638
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
AndrewSisley
added a commit
that referenced
this pull request
Jan 10, 2025
## Relevant issue(s) Resolves #3365 ## Description Completes the fix started in #3366 - I missed a test case there and only tested with docs created after the patch. This adds a new test, testing with docs created before the patch, and then updates all index related references from col.ID to col.RootID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #3365
Description
Maintains indexes across schema versions.
This is a quick, short term fix. Long term I think we need to store the index descriptions correctly on the collection, as the current method is unexpected, and very error prone (there are lots of aggressively coded defensive
col.loadIndexcalls dotted about).Big shout out to @jsimnz , who did a lot of the hard work in narrowing down the bug last night leaving me with the easy fix in the morning :)