fix: Resolve CORS errors in OpenAPI tab of Playground #3263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3263 +/- ##
===========================================
+ Coverage 77.53% 78.01% +0.48%
===========================================
Files 382 382
Lines 35263 35308 +45
===========================================
+ Hits 27341 27544 +203
+ Misses 6296 6127 -169
- Partials 1626 1637 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 58 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ChrisBQu
changed the title
fredcarle
requested changes
Nov 21, 2024
fredcarle
requested changes
Nov 21, 2024
fredcarle
approved these changes
Nov 22, 2024
ChrisBQu
added a commit
to ChrisBQu/defradb
that referenced
this pull request
Feb 21, 2025
…3263) ## Relevant issue(s) Resolves sourcenetwork#2458 ## Description There was a bug in the Playground's OpenAPI tool. This tool would list the URL of the endpoints as localhost instead of 127.0.0.1 (which is what the startup Defradb message shows.) The result was that attempting to execute one of the queries returned a CORS error. This was a one-liner fix. I adjusted openapi.go to use `http://127.0.0.1:9181/api/v0` as a string literal for the URL, instead of `http://localhost:9181/api/v0` ## Tasks - [x] I made sure the code is well commented, particularly hard-to-understand areas. - [x] I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in nts, ## How has this been tested? The platform(s) on which this was tested: - Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #2458
Description
There was a bug in the Playground's OpenAPI tool. This tool would list the URL of the endpoints as localhost instead of 127.0.0.1 (which is what the startup Defradb message shows.) The result was that attempting to execute one of the queries returned a CORS error.
This was a one-liner fix. I adjusted openapi.go to use
http://127.0.0.1:9181/api/v0as a string literal for the URL, instead ofhttp://localhost:9181/api/v0Tasks
How has this been tested?
The platform(s) on which this was tested: