-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for cid-only time travel queries #3256
feat: Add support for cid-only time travel queries #3256
Conversation
bbe6d72
to
db13086
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3256 +/- ##
===========================================
- Coverage 77.56% 77.50% -0.06%
===========================================
Files 382 382
Lines 35301 35294 -7
===========================================
- Hits 27379 27354 -25
- Misses 6291 6307 +16
- Partials 1631 1633 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I was going to ask to remove the dskey and docID references on the versioned fetcher but I noticed you took care of it in your other PR 👍
## Relevant issue(s) Resolves sourcenetwork#3214 ## Description Adds support for cid-only time travel queries. Also removes some dead code.
Relevant issue(s)
Resolves #3214
Description
Adds support for cid-only time travel queries.
Collection-level commit don't work yet, but I'm going to sort that out in another branch.
Also removes some dead code.