Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for cid-only time travel queries #3256

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

AndrewSisley
Copy link
Contributor

@AndrewSisley AndrewSisley commented Nov 19, 2024

Relevant issue(s)

Resolves #3214

Description

Adds support for cid-only time travel queries.

Collection-level commit don't work yet, but I'm going to sort that out in another branch.

Also removes some dead code.

@AndrewSisley AndrewSisley added feature New feature or request area/query Related to the query component labels Nov 19, 2024
@AndrewSisley AndrewSisley added this to the DefraDB v0.15 milestone Nov 19, 2024
@AndrewSisley AndrewSisley requested a review from a team November 19, 2024 18:19
@AndrewSisley AndrewSisley self-assigned this Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.50%. Comparing base (27893cf) to head (db13086).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3256      +/-   ##
===========================================
- Coverage    77.56%   77.50%   -0.06%     
===========================================
  Files          382      382              
  Lines        35301    35294       -7     
===========================================
- Hits         27379    27354      -25     
- Misses        6291     6307      +16     
- Partials      1631     1633       +2     
Flag Coverage Δ
all-tests 77.50% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/db/fetcher/versioned.go 75.69% <100.00%> (-0.23%) ⬇️
internal/planner/select.go 84.85% <100.00%> (+0.14%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27893cf...db13086. Read the comment docs.

---- 🚨 Try these New Features:

AndrewSisley added a commit to AndrewSisley/defradb that referenced this pull request Nov 20, 2024
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I was going to ask to remove the dskey and docID references on the versioned fetcher but I noticed you took care of it in your other PR 👍

@AndrewSisley AndrewSisley merged commit c45b07e into sourcenetwork:develop Nov 20, 2024
42 of 43 checks passed
@AndrewSisley AndrewSisley deleted the 3214-cid-only-tt branch November 20, 2024 09:48
ChrisBQu pushed a commit to ChrisBQu/defradb that referenced this pull request Feb 21, 2025
## Relevant issue(s)

Resolves sourcenetwork#3214

## Description

Adds support for cid-only time travel queries.

Also removes some dead code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/query Related to the query component feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Querying docs with just a cid (no docID) panics
2 participants