test: Allow assertion of AddSchema results #2788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
area/schema
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2788 +/- ##
===========================================
- Coverage 78.84% 78.79% -0.05%
===========================================
Files 315 315
Lines 23835 23835
===========================================
- Hits 18792 18780 -12
- Misses 3670 3677 +7
- Partials 1373 1378 +5
Flags with carried forward coverage won't be shown. Click here to find out more. see 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
AndrewSisley
force-pushed
the
2766-assert-add-schema-result
branch
2 times, most recently
from
1401594 to
da05e98
Compare
Will be used for asserting AddSchema results too soon. No code has changed, only moved (plus a copy/cast in getCollections).
Bit odd that this wasn't done before, not sure why
AndrewSisley
force-pushed
the
2766-assert-add-schema-result
branch
from
da05e98 to
1160308
Compare
AndrewSisley
added a commit
to AndrewSisley/defradb
that referenced
this pull request
Jun 28, 2024
fredcarle
reviewed
Jun 28, 2024
|
|
||
| if expected.Indexes != nil || len(actual.Indexes) != 0 { | ||
| // Dont bother asserting this if the expected is nil and the actual is nil/empty. | ||
| // This is to say each test action from having to bother declaring an empty slice (if there are no indexes) |
There was a problem hiding this comment.
typo: This is to save? Same thing bellow.
ChrisBQu
pushed a commit
to ChrisBQu/defradb
that referenced
this pull request
Feb 21, 2025
## Relevant issue(s) Resolves sourcenetwork#2766 ## Description Allows assertion of AddSchema results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #2766
Description
Allows assertion of AddSchema results.
PR Does not attempt to spread it's usage (out of scope).