fix: Return slice of correct length from db.AddSchema #2765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
fredcarle
approved these changes
Jun 24, 2024
Values are appended to this slice
AndrewSisley
force-pushed
the
2764-create-col-return-slice
branch
from
5e78787 to
e3b9fba
Compare
Thanks for finding it :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2765 +/- ##
===========================================
+ Coverage 78.16% 78.23% +0.07%
===========================================
Files 310 310
Lines 23071 23071
===========================================
+ Hits 18032 18049 +17
+ Misses 3669 3658 -11
+ Partials 1370 1364 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ChrisBQu
pushed a commit
to ChrisBQu/defradb
that referenced
this pull request
Feb 21, 2025
…2765) ## Relevant issue(s) Resolves sourcenetwork#2764 ## Description Return slice of correct length from db.AddSchema, values are appended to this slice later in the function, but the result declaration is done as if they will be set by index. Bug also affected `db.AddView`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #2764
Description
Return slice of correct length from db.AddSchema, values are appended to this slice later in the function, but the result declaration is done as if they will be set by index.
Bug also affected
db.AddView.I'll create a ticket to allow us to test this properly (the results ofTicket created: #2766AddSchema andAddView` are never asserted by our integration tests atm).